Skip to content

Make action card items slightly smaller#3184

Merged
Crabcyborg merged 2 commits into
masterfrom
make_action_card_items_slightly_smaller
Jul 13, 2026
Merged

Make action card items slightly smaller#3184
Crabcyborg merged 2 commits into
masterfrom
make_action_card_items_slightly_smaller

Conversation

@Crabcyborg

@Crabcyborg Crabcyborg commented Jul 13, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

This is part of the design for reducing the size of the form action card items.

  • Reduce the action title from 16px to 14px.
  • Reduce the action description from 14px to 13px.
  • Card padding from 16px to 12px.
  • Icon container from ~41px to 36px.
Screenshot 2026-07-13 at 2 28 03 PM

Summary by CodeRabbit

  • Style
    • Improved the visual consistency of admin action cards with standardized spacing, typography, and icon sizing.
    • Enhanced hover transitions and adjusted action-card grid sizing for a more polished layout.
    • Refined action heading styling for improved readability.

@Crabcyborg Crabcyborg added this to the 6.33 milestone Jul 13, 2026
@coderabbitai

coderabbitai Bot commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Admin action card styles now use updated spacing, transitions, typography, icon sizing, and grid dimensions. The generated admin CSS reflects these SCSS changes, and the action icon heading no longer applies the frm-text-md class.

Changes

Admin action card presentation

Layer / File(s) Summary
Action card presentation styles
resources/scss/admin/components/form/_form-actions.scss, css/frm_admin.css, classes/views/frm-form-actions/_action_icon.php		 Outlined action cards now use updated margins and transitions; action cards have standardized padding, typography, icon dimensions, and grid sizing. Generated admin CSS and the action icon heading class list reflect the updates.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: shervelmi, stephywells

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: reducing action card item sizes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch make_action_card_items_slightly_smaller

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@deepsource-io

deepsource-io Bot commented Jul 13, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 6957fcd...d4f3c77 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Jul 13, 2026 5:28p.m. Review ↗
JavaScript Jul 13, 2026 5:28p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

coderabbitai[bot]
coderabbitai Bot reviewed Jul 13, 2026
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@resources/scss/admin/components/form/_form-actions.scss`:
- Around line 97-103: Apply the 14px action-title styling consistently: update
the .frm-action.frm-card-item h3 rule in
resources/scss/admin/components/form/_form-actions.scss (lines 97-103) with
var(--text-sm), regenerate css/frm_admin.css (line 1), preserve the installed
heading without frm-text-md in classes/views/frm-form-actions/_action_icon.php
(line 39), and remove frm-text-md from the not-installed heading in
classes/views/frm-form-actions/settings.php (line not specified).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a3bb780f-3769-4395-a676-342044d7824c

📥 Commits

Reviewing files that changed from the base of the PR and between 6957fcd and d4f3c77.

📒 Files selected for processing (3)
  • classes/views/frm-form-actions/_action_icon.php
  • css/frm_admin.css
  • resources/scss/admin/components/form/_form-actions.scss

Comment thread resources/scss/admin/components/form/_form-actions.scss
Comment on lines +97 to +103
.frm-action.frm-card-item {
padding: 12px !important;
}

.frm-action.frm-card-item h3 + p {
font-size: 13px;
}

@coderabbitai coderabbitai Bot Jul 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Apply the 14px action-title rule consistently across source, generated CSS, and card templates.

The action-card h3 has no scoped 14px declaration, while the not-installed template still applies frm-text-md at 16px with !important.

  • resources/scss/admin/components/form/_form-actions.scss#L97-L103: add font-size: var(--text-sm) to the action-card h3.
  • css/frm_admin.css#L1: regenerate the compiled stylesheet with that rule.
  • classes/views/frm-form-actions/_action_icon.php#L39-L39: keep the installed template without frm-text-md, and remove the same class from the not-installed heading in classes/views/frm-form-actions/settings.php.
📍 Affects 3 files
  • resources/scss/admin/components/form/_form-actions.scss#L97-L103 (this comment)
  • css/frm_admin.css#L1-L1
  • classes/views/frm-form-actions/_action_icon.php#L39-L39
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@resources/scss/admin/components/form/_form-actions.scss` around lines 97 -
103, Apply the 14px action-title styling consistently: update the
.frm-action.frm-card-item h3 rule in
resources/scss/admin/components/form/_form-actions.scss (lines 97-103) with
var(--text-sm), regenerate css/frm_admin.css (line 1), preserve the installed
heading without frm-text-md in classes/views/frm-form-actions/_action_icon.php
(line 39), and remove frm-text-md from the not-installed heading in
classes/views/frm-form-actions/settings.php (line not specified).

@Crabcyborg
Crabcyborg merged commit 67afddc into master Jul 13, 2026
44 of 48 checks passed
@Crabcyborg
Crabcyborg deleted the make_action_card_items_slightly_smaller branch July 13, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

run analysis run tests

Projects

None yet

Milestone

6.33

Development

Successfully merging this pull request may close these issues.

1 participant

@Crabcyborg